Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previews exported files, adds preview tests #1766

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Oct 18, 2024

closes #1694

@Fil Fil requested a review from mbostock October 18, 2024 10:12
@Fil Fil enabled auto-merge (squash) October 18, 2024 10:12
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to enforce that the required file is listed in dynamicPaths, no?

@Fil
Copy link
Contributor Author

Fil commented Dec 3, 2024

It's not something that we're doing for parameterized pages and resources, i.e. you can call page-foo if there is a page-[var].md, even if that parameter is not listed in dynamicPaths.

Maybe we should (at least) log a line of warning? Another approach might be to return a 404 with an explicit message that says “this resource exists and we could serve it if you declared it in dynamicPaths”… or even maybe a button to bypass that problem, when you're developing something and don't want to get thrown out of your flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preview static assets
2 participants